Add clause to TextUtils.sendEmail to allow for HTML-only reports #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…matted and are ready to send as-is)
|
Follow-up:
Please let me know if you have any questions or concerns about this change, or would like to run tests on your end. Thanks! -Shreyas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the upgrade to python3, gracc-reporting seems to have lost the ability to allow for multipart report emails where only an HTML block was given to
sendEmail. This is a feature we use for all of the FIFE reports at Fermilab - we generate the HTML from external templates that are packaged with the reports - so I believe the addition of these two lines would allow for such emails to be sent.Please let me know what you all think or if you have any questions.
Draft status: